CSS: WPT for basic-shape <position> parsing #9343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 1, 2018
Build PASSEDStarted: 2018-02-01 23:41:50 Failing Jobs
View more information about this build on: |
Test that basic shapes support the <position> grammar https://drafts.csswg.org/css-shapes/#typedef-basic-shape https://drafts.csswg.org/css-values-4/#typedef-position and not the additional forms allowed by the <bg-position> grammar https://drafts.csswg.org/css-backgrounds-3/#propdef-background-position Blink has deprecated <bg-position> support in basic shapes (and other contexts other than background-position), so the expected failures are while we wait for removal in M68. BUG=804187 Change-Id: Ifcaa72f42f2b63730ec761bf4fff4d4557f82b75 Reviewed-on: https://chromium-review.googlesource.com/897071 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#533849}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-897071
branch
from
92961fd
to
17cb568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that basic shapes support the grammar
https://drafts.csswg.org/css-shapes/#typedef-basic-shape
https://drafts.csswg.org/css-values-4/#typedef-position
and not the additional forms allowed by the grammar
https://drafts.csswg.org/css-backgrounds-3/#propdef-background-position
Blink has deprecated support in basic shapes
(and other contexts other than background-position), so the expected
failures are while we wait for removal in M68.
BUG=804187
Change-Id: Ifcaa72f42f2b63730ec761bf4fff4d4557f82b75
Reviewed-on: https://chromium-review.googlesource.com/897071
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Eric Willigers ericwilligers@chromium.org
Cr-Commit-Position: refs/heads/master@{#533849}